Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor corrections in style spec documentation #5959

Closed
wants to merge 1 commit into from
Closed

Minor corrections in style spec documentation #5959

wants to merge 1 commit into from

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 6, 2018

Made two small changes to the style specification JSON to facilitate better codegen results in mapbox/mapbox-gl-native#10850:

  • icon-offset uses backticks around the reference to icon-size so that icon-size can become iconScale on iOS/macOS.
  • Indicated that {token} replacement is also unavailable in data expressions. At least that’s the case in the native implementation; not sure about GL JS.

/cc @jfirebaugh

@1ec5 1ec5 added cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) docs 📜 labels Jan 6, 2018
@1ec5 1ec5 self-assigned this Jan 6, 2018
@1ec5 1ec5 requested a review from jfirebaugh January 6, 2018 02:14
@1ec5 1ec5 mentioned this pull request Jan 6, 2018
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 6, 2018

Closing in light of #5958 and #5600.

@1ec5 1ec5 closed this Jan 6, 2018
@jfirebaugh jfirebaugh deleted the 1ec5-style-spec-doc-nits branch February 22, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh Awaiting requested review from jfirebaugh

Assignees

@1ec5 1ec5

Labels
cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) docs 📜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@1ec5